search

UniFormal / MMT

The MMT Language and System
https://uniformal.github.io/
Other
68 stars 23 forks source link

lmh install does not work on Windows even when git is in Path #477

Open rappatoni opened 5 years ago

rappatoni commented 5 years ago

This appears to be due to MMT attempting to use the sh-shell on Windows.

ComFreek commented 5 years ago

Relevant code: https://github.com/UniFormal/MMT/blob/31cfdd630ad5a817d8768081c3cdf95aed50925c/src/mmt-api/src/main/info/kwarc/mmt/api/archives/Git.scala#L40

The documentation should be updated when this issue is resolved: https://github.com/UniFormal/uniformal.github.io/blob/master/doc/applications/intellij.md

rappatoni commented 4 years ago

This is technically solved through the documentation pointer to put sh in the path. However, dispensing with the need for sh would simplify the installation process on windows.

tkw1536 commented 4 years ago

For historical context: When @florian-rabe initially implemented support for using git on windows, he used a git installation that added sh by default. The code should really check if git is in $PATH and use it directly when available.

ComFreek commented 4 years ago

@florian-rabe This bug again caught me today. Can we please get rid of sh on Windows and just use Git as-is?

There are nice solutions out there for configuring Git on Windows with SSH keys support. I have been using KeePass + KeeAgent flawlessly for years now :smile:

tkw1536 commented 4 years ago

We could hide it behind an option, like we do for ssh support.

tkw1536 commented 4 years ago

And have the old (with sh) behavior for those that rely on it.

ComFreek commented 3 years ago

Months ago, I aligned the behavior of how git is invoked on *nix systems and Windows:

https://github.com/UniFormal/MMT/blob/59c8a36bc7d73aa8b7c30f93da2407627e1941e5/src/mmt-api/src/main/info/kwarc/mmt/api/archives/Git.scala#L40

This means on Windows that you now have to set up your Git to use SSH keys correctly. If you don't know how to do that, I've written a guide on comfortably using SSH keys on Windows.