UniMainzGeo / LaMEM

LaMEM (Lithosphere and Mantle Evolution Model) - a 3D parallel code to simulate geodynamic and geomechanical processes
MIT License
50 stars 16 forks source link

Added new inflow from boundary condition options #2

Closed IskanderI closed 1 year ago

IskanderI commented 1 year ago

New feature: changing inflow boundary - this PR allows the inflow velocity to change through time.

I rewrote reading from *.dat file: 1) now bvel_velin can be an array instead of a scalar and it writes to a different array. 2) The time is given in a different array velin_time_delims which takes the corresponding velocity and assigns it as bc.velin.

The same function calculates bc.velout as before. It is all similar to function BCGetBGStrainRates. I also added separate folder in tests (t32_BC_velocity) with an example of how to use it. This function doesn't change any workflow in usual models with only one velocity. To use it:

_lameminput file has been updated accordingly

boriskaus commented 1 year ago

could you add a description on what this PR does and how to activate these new features? This helps if we later want to search this

IskanderI commented 1 year ago

Should I do new PR with new description and close this?

boriskaus commented 1 year ago

no, this is fine. I initially didn't see your description, but I now reformatted this a little bit to make it more readable.

I have assigned Anton as reviewer.

sgeotech commented 1 year ago

I promise to review it promptly, within next three months or so :)