Closed IskanderI closed 1 year ago
could you add a description on what this PR does and how to activate these new features? This helps if we later want to search this
Should I do new PR with new description and close this?
no, this is fine. I initially didn't see your description, but I now reformatted this a little bit to make it more readable.
I have assigned Anton as reviewer.
I promise to review it promptly, within next three months or so :)
New feature: changing inflow boundary - this PR allows the inflow velocity to change through time.
I rewrote reading from
*.dat
file: 1) nowbvel_velin
can be an array instead of a scalar and it writes to a different array. 2) The time is given in a different arrayvelin_time_delims
which takes the corresponding velocity and assigns it asbc.velin
.The same function calculates
bc.velout
as before. It is all similar to functionBCGetBGStrainRates
. I also added separate folder in tests (t32_BC_velocity
) with an example of how to use it. This function doesn't change any workflow in usual models with only one velocity. To use it:specify _velin_num_periods_ (INT) for a numbers of changing periods
_velin_time_delims_ (ARRAY) in Ma for an age when to change for a next period (one less than period number!)
_bvel_velin_ (ARRAY) velocities for specified period
With changing _face_out_ parameter to -1, 0 or 1 it is possible to change the behaviour of opposite boundary
_lameminput file has been updated accordingly