Closed fredrik-bakke closed 8 months ago
I will review this PR myself a little later. In the meanwhile, since I believe it is close to done I will mark it as ready for review.
I've marked this PR as ready for review again. I'll request a review specifically from Egbert, as he may have some objections to the refactor.
Thank you for the review, it is most helpful!
Your suggestions are very sensible, and I think they will heighten the quality of this refactoring substantially.
We could perhaps consider doing a file about type arithmetic for standard pullbacks, recording such things as
How's this?
I've addressed your comments as best I can. Let me know if there is anything else to do or if this PR is ready for merging.
I'm gonna go ahead and merge this PR as I need it to continue my work. If there are any future comments, I can fix them in a subsequent PR.
foundation(-core).pullbacks
into a treatment for standard pullbacks infoundation(-core).standard-pullbacks
, and cones satisfyingis-pullback
infoundation(-core).pullbacks
. This makes the file about pullbacks much more readable, finally.foundation.pullback-squares
because it was just a stub, and led to misuse in some places. After a refactoring of cones, we may want an additional file about pullback cones.