UniMath / agda-unimath

The agda-unimath library
https://unimath.github.io/agda-unimath/
MIT License
222 stars 71 forks source link

Factor out standard pullbacks #1042

Closed fredrik-bakke closed 8 months ago

fredrik-bakke commented 8 months ago
fredrik-bakke commented 8 months ago

I will review this PR myself a little later. In the meanwhile, since I believe it is close to done I will mark it as ready for review.

fredrik-bakke commented 8 months ago

I've marked this PR as ready for review again. I'll request a review specifically from Egbert, as he may have some objections to the refactor.

fredrik-bakke commented 8 months ago

Thank you for the review, it is most helpful!

fredrik-bakke commented 8 months ago

Your suggestions are very sensible, and I think they will heighten the quality of this refactoring substantially.

fredrik-bakke commented 8 months ago

We could perhaps consider doing a file about type arithmetic for standard pullbacks, recording such things as

fredrik-bakke commented 8 months ago

How's this?

fredrik-bakke commented 8 months ago

I've addressed your comments as best I can. Let me know if there is anything else to do or if this PR is ready for merging.

fredrik-bakke commented 8 months ago

I'm gonna go ahead and merge this PR as I need it to continue my work. If there are any future comments, I can fix them in a subsequent PR.