UniMath / agda-unimath

The agda-unimath library
https://unimath.github.io/agda-unimath/
MIT License
222 stars 71 forks source link

Move torsoriality of the identity type to `foundation-core.torsorial-type-families` #1065

Closed EgbertRijke closed 8 months ago

EgbertRijke commented 8 months ago

This PR moves the torsoriality of the identity types to foundation-core.torsorial-type-families. Previously it was in contractible-types. I also slightly updated the prose, and fixed imports wherever they were broken because of this move.

fredrik-bakke commented 8 months ago

Would it be nice to also mention in the ## Idea section that the identity type family is the motivating example of the definition?

EgbertRijke commented 8 months ago

Question: When running make website I get the following error. What should I do to make it go away?

Traceback (most recent call last):
  File "/Users/egbertrijke/Repositories/agda-unimath/./scripts/preprocessor_citations.py", line 8, in <module>
    import pybtex
ModuleNotFoundError: No module named 'pybtex'
fredrik-bakke commented 8 months ago

Question: When running make website I get the following error. What should I do to make it go away?

Traceback (most recent call last):
  File "/Users/egbertrijke/Repositories/agda-unimath/./scripts/preprocessor_citations.py", line 8, in <module>
    import pybtex
ModuleNotFoundError: No module named 'pybtex'

You have to install the latest requirements. What you're missing is the pybtex module

VojtechStep commented 8 months ago

I'd expect this property to be recorded in foundation.identity-types - are there circular dependency issues with that?

fredrik-bakke commented 8 months ago

Question: When running make website I get the following error. What should I do to make it go away?

Traceback (most recent call last):
  File "/Users/egbertrijke/Repositories/agda-unimath/./scripts/preprocessor_citations.py", line 8, in <module>
    import pybtex
ModuleNotFoundError: No module named 'pybtex'

You have to install the latest requirements. What you're missing is the pybtex module

The command would be pip3 install -r scripts/requirements.txt unless you've recently updated python with brew. If so, the command is pip3 install -r scripts/requirements.txt --break-system-packages

EgbertRijke commented 8 months ago

I'd expect this property to be recorded in foundation.identity-types - are there circular dependency issues with that?

You're right, and yes that leads to cyclic module dependencies that I don't want to solve now.

EgbertRijke commented 8 months ago

Would it be nice to also mention in the ## Idea section that the identity type family is the motivating example of the definition?

On it.

EgbertRijke commented 8 months ago

I removed "chore" from the title of this PR because I wrote a somewhat substantial amount of text and that should definitely count as content creation.