UniMath / agda-unimath

The agda-unimath library
https://unimath.github.io/agda-unimath/
MIT License
219 stars 70 forks source link

Splitting idempotents #1105

Closed fredrik-bakke closed 5 months ago

fredrik-bakke commented 6 months ago

Summary

Work towards #1103.

fredrik-bakke commented 6 months ago

Since I won't be able to finish this PR before I leave tomorrow, let me write down some thoughts here for when I pick this up again.

It's sensible to make a new file for infinitely coherent idempotent maps, but then one may ask if the proof that quasiidempotents split fits better in that file. There is also a question of whether we want more agda-unimath like names for is-preidempotent and is-quasiidempontent. My initial suggestions would be is-idempotent for the former, mirroring e.g. is-involution which is not coherent either, and is-quasicoherent-idempotent for the latter.

Any other nice and easy consequences of this formalization?

fredrik-bakke commented 6 months ago

I also need to verify that the diagrams render properly

fredrik-bakke commented 6 months ago

To partition this work up a bit, I may aim to formalize fully coherent idempotents in a subsequent PR. It still remains to tidy up this PR before it is ready for review, however.

fredrik-bakke commented 5 months ago

A couple of questions remain:

fredrik-bakke commented 5 months ago

This PR is now open to reviews. @tomdjong said he was interested in reviewing this, so I'll tag him :)

fredrik-bakke commented 5 months ago

Is this PR ready to merge? I can formalize the counter-example in a subsequent PR thanks to #1115

EgbertRijke commented 5 months ago

Is this PR ready to merge? I can formalize the counter-example in a subsequent PR thanks to #1115

Great work, I'll turn on the auto-merge