search

UniNE-CHYN / mmappickle

Python 3 library to store memory mappable objects into pickle-compatible files
http://mmappickle.readthedocs.io
GNU Lesser General Public License v3.0
37 stars 4 forks source link

JOSS - Test coverage #14

Closed clemaitre58 closed 6 years ago

clemaitre58 commented 6 years ago

Hi, Could you add some test to verify the support of 'nt' in source : utils.py https://coveralls.io/builds/16773337/source?filename=mmappickle/utils.py

lfasnacht commented 6 years ago

Actually, it is covered by the tests (running on AppVeyor), but coveralls doesn't see it because the coverage is uploaded by travis-ci on Linux.

It seems not possible to sum the coverage as far as I know (and according to https://github.com/lemurheavy/coveralls-public/issues/544).

clemaitre58 commented 6 years ago

Could you provide a AppVeyor results?

lfasnacht commented 6 years ago

Well, not on coveralls (it would overwrite the results of travis, and therefore would not cover 'posix' systems). I can provide you the coverage on a windows computer if you want (there is nearly no difference, as it is the only part where I have platform dependant code), but later as I'm using Linux now ;-)

Or you can run on your computer, if you happen to have Windows:

py.test --cov=mmappickle
clemaitre58 commented 6 years ago

@lfasnacht Yes I am interested in the coverage on the windows computer

lfasnacht commented 6 years ago

OK, I will do it this evening if I have time.

clemaitre58 commented 6 years ago

TY.

lfasnacht commented 6 years ago

I tried to add the coverage to appveyor.yml, the output should appear in the build logs at appveyor (it's awfully slow):

https://ci.appveyor.com/project/lfasnacht/mmappickle/

lfasnacht commented 6 years ago

It worked:

Name                              Stmts   Miss  Cover   Missing
---------------------------------------------------------------
mmappickle\__init__.py                3      0   100%
mmappickle\_version.py                1      0   100%
mmappickle\dict.py                  459      6    99%   820-826
mmappickle\picklers\__init__.py       9      2    78%   10-12
mmappickle\picklers\base.py          84      6    93%   27, 33, 38, 46, 79-80
mmappickle\picklers\numpy.py        109      7    94%   41, 81, 83, 87, 107, 109, 116
mmappickle\stubs\__init__.py          7      2    71%   7-9
mmappickle\stubs\numpy.py            12      0   100%
mmappickle\utils.py                  66     13    80%   14-18, 30-34, 72-77, 84
---------------------------------------------------------------
TOTAL                               750     36    95%
clemaitre58 commented 6 years ago

Ok great!