UniNE-CHYN / mmappickle

Python 3 library to store memory mappable objects into pickle-compatible files
http://mmappickle.readthedocs.io
GNU Lesser General Public License v3.0
37 stars 4 forks source link

JOSS - Version #5

Closed glemaitre closed 6 years ago

glemaitre commented 6 years ago

There is no variable __version__ accessible which is usually something quite standard. You should create a _version.py module in which you define the version and import it in __init__.py You can read _version.py inside the setup.py to not have to import directly.

Basically I am expecting something like:

import mmappickle
print(mmappickle.__version__)
'1.0.0'
glemaitre commented 6 years ago

you might want to consider to start your versioning at 0.1.0 since that you don't have a major revision. But I let you as you want since that there is not strong enforcement regarding the versioning

lfasnacht commented 6 years ago

My plan is to use the major version as the file format, the minor when there are API changes, and the revisions for... revisions (what a surprise!).

As a matter of fact, I have files which were created by an unreleased version of mmappickle, which are of version 0.

I plan to do a 1.0.1 release when all the issues are fixed.

glemaitre commented 6 years ago

Ok good for me :)

On 24 April 2018 at 12:41, Laurent Fasnacht notifications@github.com wrote:

My plan is to use the major version as the file format, the minor when there are API changes, and the revisions for... revisions (what a surprise!).

As a matter of fact, I have files which were created by an unreleased version of mmappickle, which are of version 0.

I plan to do a 1.0.1 release when all the issues are fixed.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/UniNE-CHYN/mmappickle/issues/5#issuecomment-383886301, or mute the thread https://github.com/notifications/unsubscribe-auth/AHG9P0QpiVfFPO9dl7xCQHaBfWWDYZviks5trwE-gaJpZM4TgLr7 .

-- Guillaume Lemaitre INRIA Saclay - Parietal team Center for Data Science Paris-Saclay https://glemaitre.github.io/