search

UniRegensburg / unsere-app-fur-die-universitat-regensburg-bib-buddy

Bib Buddy - deine App für eine konzentrierte, offene Literaturarbeit!
0 stars 0 forks source link

Create filter for search results (see Issue #88) #108

Closed claudia3 closed 3 years ago

claudia3 commented 3 years ago

Description Closes #88. Create filter for shelves, books and notes in the search. Multiple filter can be selected at once.

Affects Mainly the search.

Notes for Reviewer You can filter the search results when you use the menu in the right corner of the header. Please review & comment/approve.

silvia-ivanova-github-rep commented 3 years ago

Please fix the checkstyle errors in order to write a review.

claudia3 commented 3 years ago

Currently it is supposed to search for something. But in my next PR on which I currently work on I have to change it because I have to write a different class that I can use the sort functions in the other views of our app.

silvia-ivanova-github-rep commented 3 years ago

Also if I have a result list after setting a filter or filters and then select some item of the result list (e.g. book) and then go back - then my list of results after filtering is deleted. Should it not be visible?

claudia3 commented 3 years ago

Because it is a sort class and sort and filter are different aspects. The problem is that when you click the backButton and create the SearchFragment again the searchInput is an empty String even if there is text in there. This is described in a TODO comment.