search

UniRegensburg / unsere-app-fur-die-universitat-regensburg-bib-buddy

Bib Buddy - deine App für eine konzentrierte, offene Literaturarbeit!
0 stars 0 forks source link

Share and Import Buttons in Header #115

Closed silvia-ivanova-github-rep closed 3 years ago

silvia-ivanova-github-rep commented 3 years ago

Description As discussed with the team the buttons for sharing and importing of BibTeX files are added to the header of the App.

Affects UI

Notes for Reviewer Please check if the share and import buttons are only shown in LibraryFragment, BookFragment, and BookNotesView. Since the share function is currently not implemented -> for the share button, you should have an export of BibTeX.

Please review & comment/approve. Thanks!

silvia-ivanova-github-rep commented 3 years ago

Sarah, thanks for the review.

Please set the visibility of the buttons in the xml to invisible by default to omit code.

As discussed above, this approach did not work, so no changes are required.

The import button is missing in the LibraryFragment.

In LibraryFragment there is no import button because you cannot import a BibTeX file, since you do not know in which shelf to import. This was also discussed in the team meeting last week.

If you press the import button and select a file, the app crashes.

It is working for me, I did not change anything in the code, since the last review of the import of BibTeX. Are you sure that you test the app on Android 10 (API 29)? Android 10 (API 29) is our target Android version.