UniRegensburg / unsere-app-fur-die-universitat-regensburg-bib-buddy

Bib Buddy - deine App für eine konzentrierte, offene Literaturarbeit!
0 stars 0 forks source link

Create voice note editor #117

Closed xSabrina closed 3 years ago

xSabrina commented 3 years ago

Description

Closes #106

A voice note editor has been created - therefore noteLists in NotesFragment and BookNotesFragment have been adjusted in code and layout. The editor is only opened on creating a new voice note - existing voice notes in noteLists have small buttons to play/pause, stop and a seekBar to move through the audio.

Also did some general clean ups and changes that affected the VoiceNotes-feature or have been affected by it.

Affects

@SarahKurek should take a look since she created the view for booknotes that has been changed majorly.

Notes for Reviewer

1. General changes:

2. VoiceNoteEditorFragment:

3. NotesFragment and BookNotesFragment:

4. Database related (NoteModel, NoteDao, etc.):

5. Suggestions for your testing:

xSabrina commented 3 years ago

Next time please don't do everything on one branch, because now merging with my design changes will be difficult.

I agree, sorry for now though. I merged conflicts manually.

Help will be integrated into the bottom navigation bar and should, in my opinion, remain as a separate view. Therefore, please reverse the changes in this regard.

We talked about this in our meeting already - so I will leave the changes.

Name changes to classes that are being edited by others at the same time are likely to cause merge problems and should only be made after consultation. So undo the renaming and fix the checkstyle warning please.

True - there is no undoing necessary though, I fixed possible merge conflicts already.

xSabrina commented 3 years ago

I solved all merge conflicts and fixed some bugs.

Mainly fixing the bug from #119: Also limited the possible recording duration for voice notes to 1 Min. to avoid crashes from too large byte arrays for our database blobs. I chose the limit in time and not file size, because it is more resource saving to use a countDown instead of permanently checking the temporary-recording-file for its size. I chose 1 minute as limit since it is almost the biggest possible size and a plain value. If the record extends over 1 Min. the audio is saved as a separate note (a toast to notify the user additionally) and automatically starts the next recording. Also adjusted the help strings for the voice note editor to this.

LuisMossburger commented 3 years ago

As discussed in team meeting, this PR will be closed as further major changes are needed.