search

UniRegensburg / unsere-app-fur-die-universitat-regensburg-bib-buddy

Bib Buddy - deine App für eine konzentrierte, offene Literaturarbeit!
0 stars 0 forks source link

Bugfix note text without formatting tags #121

Closed LuisMossburger closed 3 years ago

LuisMossburger commented 3 years ago

Description Closes #84. Adds a new function which strips formatting tags from note text. This is used for the export function from now on.

Affects Export function and Note.

Notes for Reviewer Please review & comment/approve. Thanks! See this example to review the new regex: https://regex101.com/r/V3CgIs/1

LuisMossburger commented 3 years ago

@silvia-ivanova-github-rep Please wait until #117 is merged before reviewing :) Thanks!

LuisMossburger commented 3 years ago

Hey, thanks for the review! As far as I can tell, both problems do not arise from the code I wrote, however.

1) "<" instead of ">" arises because special signs are encoded when stored into the database. I can decode that for the export, but that should be discussed in the team meeting I think.

2) Import of note - that is a separate bug probably somewhere in the "import" section you wrote yourself? I did not change anything regarding import functions.

LuisMossburger commented 3 years ago

For the protocol: We had a chat and think we should create new issues for both of these problems, as they are not directly related to the original bug here. This PR will be merged after #117 is.

LuisMossburger commented 3 years ago

Pr #117 will be closed, so this can be merged!