Clean up note features - Githubissues

xSabrina commented 3 years ago

Description This branch does some changes and clean-ups to note related features:

replacing BookNotesRecyclerViewAdapter-usages with NoteRecyclerViewAdapter-usages to be consistent in using the same adapter for all notes to avoid double-code. Therefore removing the legacy BookNotesRecyclerViewAdapter class.
using the same note cardView xml (list-view-item-note) for all note-cardViews, so notes have the same GUI for the user all over the app. Therefore removing the legacy list-view-item-book-note.xml.
adjusting the database and note-object handling to use a string as noteFile-column to put a path to future voice notes in it (instead of the blob).
removing image note related code or features (like the NoteImageItem or commented commented code).
removing the hidden delete panel in NotesFragment to be consistent in delete-options all over the app (now contained in options menu).
adjusting NotesFragment to have a delete-option visible in the optionsMenu whenever at least one note is selected.
fixing a bug when canceling deleting notes did not deselect them in BookNotesView: deselect-method was called at wrong position.
adjusting NotesFragment to have an delete-alertDialog for the user to decide, if he wants to perform the delete or cancel it (also to be consistent all over the app)
adding an TextView in case there are no notes to give the user feedback and be consistent all over the app.
some clean-ups to affected classes (removing legacy unused constructors, checkstyling, renaming etc.).

Affects Multiple classes related to notes.

Notes for Reviewer Please review & comment/approve.

LuisMossburger commented 3 years ago

Hey, since the earlier PR #128 was merged there are now merge conflicts - could you please resolve those before I do my review? :) Thanks!

xSabrina commented 3 years ago

Hey, since the earlier PR #128 was merged there are now merge conflicts - could you please resolve those before I do my review? :) Thanks!

This was caused by using a deprecated method to fetch the selected note item number to differ the toast text on deleting items. NoteRecyclerViewAdapter has been adjusted to perfom that (instead of just providing a method to check if there is any item selected).

xSabrina commented 3 years ago

I applied all of your suggested changes - please have another look :)

UniRegensburg / unsere-app-fur-die-universitat-regensburg-bib-buddy

Clean up note features #129