UniRegensburg / unsere-app-fur-die-universitat-regensburg-bib-buddy

Bib Buddy - deine App für eine konzentrierte, offene Literaturarbeit!
0 stars 0 forks source link

Create new voice editor #144

Closed xSabrina closed 3 years ago

xSabrina commented 3 years ago

Description

Closes #106

This merges implement a new version of the feature to create and save voice notes. It mainly adjusts the note cardViews (since voice notes contain a seekbar and a play/pause and stop button) and creates a voice note editor fragment containing just a record-by-on-click button.

Here are some details on the changes:

I also did some general small note-related clean ups:

Affects

Mainly note-related features like the BookNotesView and the database as well, so @SarahKurek should take a look. Also this is just an basic design idea for the voice note features - there might be some things that need or could be adjusted, which @LuisMossburger should take note of.

Notes for Reviewer

Some suggestions for your testing:

Please review & comment/approve. Thanks!

xSabrina commented 3 years ago

The voice editor works pretty good and I'm excited to have this in the app! :)

Thanks, same here :)

Some suggestions for code refactoring, as well as the layout for the list item. Also, please use these icons for the text notes controls and the voice note editor. I probably need to create one for the list view myself.

I applied all of your suggestions, implemented your new icons and deleted the old ones - please have another look :)

xSabrina commented 3 years ago

Hey! Thanks for implementing the suggestions. However, the layout in the list view still seems to cause problems (see screenshot). If you want, I can have another look and try to fix this tomorrow..

I see - that would be cool actually since the layout looks fine on my devices it is hard to check if the changes fixed it. The layout on your screenshot looks strange however since the voice elements should be constrainted right and next to each other now.

LuisMossburger commented 3 years ago

Hey! I made some adjustments and think the layout works properly now. Basically, I wrapped the whole list item in a ConstraintLayout and added constrainedWidth="true" to make it resizeable based on the surroundings. I also adjusted the voice editor button to make it fit with the rest of the apps design. Please have a look and re-request my feedback if you agree, so I can approve :)

Also, for me the Toast after creating a voice note is not showing up anymore, is that desired behaviour?

xSabrina commented 3 years ago

Hey! I made some adjustments and think the layout works properly now. Basically, I wrapped the whole list item in a ConstraintLayout and added constrainedWidth="true" to make it resizeable based on the surroundings.

Hey, thanks for your effort! I see why this is solving the issue.

I also adjusted the voice editor button to make it fit with the rest of the apps design.

Ah, thank you - that is much better!

Also, for me the Toast after creating a voice note is not showing up anymore, is that desired behaviour?

The toast works properly for me:

voice_toast

But there was a time after our first bigger design rework when all of my toasts did not show up anymore. After wiping and reinstalling toasts worked again - maybe this might solve your problem as well.