search

UniRegensburg / unsere-app-fur-die-universitat-regensburg-bib-buddy

Bib Buddy - deine App für eine konzentrierte, offene Literaturarbeit!
0 stars 0 forks source link

Implementation of swipe function and update of delete dialogs #145

Closed SarahKurek closed 3 years ago

SarahKurek commented 3 years ago

Description See Issue #142 and #130. Swipe function for all list items was implemented. Swipe left to delete the item and swipe right to edit the item where it is appropriate. Delete dialogue is adapted so that the name of the selected items and the number of their sub-items are displayed.

Affects Deletion and editing of list elements via swipe.

Notes for Reviewer Please review & comment/approve. Thanks!

claudia3 commented 3 years ago

When you use the word "abbrechen" for the dialog add shelf, the layout "hinzufügen" button looks strange. When you rename a shelf the word "zurück" is used instead of "abbrechen". I think it should be consistent for the layouts. Screenshot_20210330_173510 Screenshot_20210330_174053

claudia3 commented 3 years ago

I just realized something when you rename a shelf it stays at the same position in the list view. Should the list be sorted again if a shelf was renamed?

claudia3 commented 3 years ago

Is it possible to implement swipe to delete if multiple items are selected? Or if the user wants to delete multiple items at once s/he should use the options menu.

claudia3 commented 3 years ago

If all notes in the BookNotesView are deleted the empty view message doesn't appear again.

claudia3 commented 3 years ago

When an audio file is deleted the view overlaps with a text note see Issue #146. This should probably be done in another PR?

claudia3 commented 3 years ago

With swipe to delete the selected item is not deleted and shows the previous note name which was already deleted. To replicate this bug just delete a note and then delete another note in the BookNotesView. Screenshot_20210330_181703

SarahKurek commented 3 years ago

Is it possible to implement swipe to delete if multiple items are selected? Or if the user wants to delete multiple items at once s/he should use the options menu.

At the moment, this is not possible and, as far as I know, would not be feasible with the used dependency. Therefore, I would only allow the deletion of more items via the menu.

claudia3 commented 3 years ago

I just realized something when you rename a shelf it stays at the same position in the list view. Should the list be sorted again if a shelf was renamed?

Will be done in another PR because the shelf renaming will be done in another fragment instead of a Dialog.