search

UniRegensburg / unsere-app-fur-die-universitat-regensburg-bib-buddy

Bib Buddy - deine App für eine konzentrierte, offene Literaturarbeit!
0 stars 0 forks source link

Code cleanup (see Issue #152) #156

Closed claudia3 closed 3 years ago

claudia3 commented 3 years ago

Description Only certain files: Use lambda functions when it is suggested by Android Studio. Reformulate some comments for consistency. Refactor code. Remove unnecessary code. Other files especially the Main Fragments will get another update because there will be bigger changes and it is more comfortable to review smaller changes in more steps.

Affects A lot of files.

Notes for Reviewer Please review & comment/approve. Thanks!

claudia3 commented 3 years ago

Hey, thanks for the work!

Some minor comments about consistent use of style in JavaDocs. One major thing: I don't think we should add "TODO" comments in a code cleanup, that rather is against the intention in my opinion. What, in your opinion, should be our "logging mechanism"?

It also seems that there is one merge conflict now due to the merging of PR #160.

I would leave the TODOs so that the code that needs to changed can be found faster. The logging mechanism will be implemented by me in a future PR.