search

UniRegensburg / unsere-app-fur-die-universitat-regensburg-bib-buddy

Bib Buddy - deine App für eine konzentrierte, offene Literaturarbeit!
0 stars 0 forks source link

Bug fix text editor #73

Closed xSabrina closed 3 years ago

xSabrina commented 3 years ago

Description

Closes #68

Some bugs related to the text editor have been fixed and some small adjustments were done as well.

  1. Edited existing notes were saved as new notes and their already existing content was missing - this is fixed now by adjusting the bundle that is given from the NoteRecyclerViewAdapter to the TextNoteEditorFragment (BTW: for editing notes from the book-views this needs to be done analogous).

  2. There was a bug whenever applying and deapplying alignments - this is working fine now.

  3. Switching between selected alignments that should exclude each other is working fine now (highlight and select the icon view and unhighlight and deselect others meanwhile).

  4. Applying and deapplying bullets caused the app to crash - this is fixed as well.

  5. Bottom navigation view was always layed above soft-keyboard (from SystemUI), which took a lot of vertical space - to avoid that the way the navigation view is layed out has been changed, so the keyboard will simply overlap it.

  6. Also adjusted the cursor position to match the applied text alignment whenever inserting a new line.

  7. Besides: some small clean ups mainly to RichTextEditor and TextNoteEditorFragment.

Affects

Mainly the Text Editor functionality, which is also affecting the BookNotesRecyclerView (because notes are created here and existing ones are editable, which needs the TextNoteEditor), and therefore @SarahKurek should take a look. As some parts are also concern the UI, it might be interesting for @LuisMossburger as well.

Notes for Reviewer

Edit an existing note from the NotesFragment (overall view for the notes) since the functionality for the BookView is not adjusted yet.

Please review & comment/approve.

claudia3 commented 3 years ago
xSabrina commented 3 years ago 
* When you edit a note and open the menu it seems to overlap with your first line. You should add a marginTop to your layout or something similar.

This was resolved in our weekly team meeting today already.

* It is just my own opinion but I don't like the pink color when you select a note. You can't read the text really well. I would prefer another color where you can read the text better. You should **use** my **color selector** **or modify** it, so that the item **colors** are **consistent** for the app.

I agree - done.

The background of the items depends on the selected state of e.g. a note item (for code see my own in "res/color/library_item_selector.xml" (definition) and "list_view_item_library.xml" (usage in line 10) (card_view:cardBackgroundColor="@color/library_item_selector")). If you do that you don't need to set the background manually in your code. If the item is selected it will show the given color in the style if not it shows your other defined color. E.g. in "NoteRecyclerViewAdapter.java" you could remove the lines 113 and 116 if you use a color selector. It saves time and trouble to correctly adapt the colors depending on the state.

This is great - thank you very much - this is done as well and also applied that procedure to the way format options are highlighted in the text note editor.

xSabrina commented 3 years ago

I recommend the changes above.

Done.

claudia3 commented 3 years ago

When you create a lot of notes the bottom navigation bar is overlapped. Will this be changed in the next PR in your other PR? You mentioned something like that to me before.

claudia3 commented 3 years ago

Problem above resolved in a small discussion