search

UniSharp / laravel-filemanager

Media gallery with CKEditor, TinyMCE and Summernote support. Built on Laravel file system.
https://unisharp.github.io/laravel-filemanager/
MIT License
2.09k stars 720 forks source link

a fix for issue #868 #1139

Closed bigzooooz closed 2 years ago

bigzooooz commented 2 years ago

(optional) Issue number: #868

Summary of the change: allows the deletion of a not-empty directory without throwing 500 error

jonnott commented 2 years ago

Would it not be better to show the error to the user, i.e. catch the exception? Do we think it's safe to allow deletion of non-empty folders? Or could it just show a warning/confirmation step first?

bigzooooz commented 2 years ago

Absolutely! Sounds like a better solution indeed.

Will make a new PR tomorrow implementing the approach you mentioned 👍