cant delete folder when there is contents

UniSharp / laravel-filemanager

Media gallery with CKEditor, TinyMCE and Summernote support. Built on Laravel file system.

https://unisharp.github.io/laravel-filemanager/

MIT License

2.09k stars 720 forks source link

cant delete folder when there is contents #1142

Closed azizikri closed 9 months ago

azizikri commented 2 years ago

Please check the following instructions before submitting a bug :

Make sure you are using the latest version.
Make sure you read installation, integration, and upgrade document.

And provide the followings :

Operating system : Windows 10
Laravel version : 8
Package version : v2.5.1
Steps to reproduce your issue : create folder and fill it with image, and delete it
Error : Method UniSharp\LaravelFilemanager\Controllers\DeleteController::error does not exist.

azizikri commented 2 years ago

update here, I think this happened because the error function is deleted in src/Controllers/LfmController.php, this was deleted in commit "b115dca3c1b089aa08c8b0b0107683668ad17279" I don't know what the purpose the code was deleted, maybe @streamtw can elaborate?

tanero commented 9 months ago

Same error still exist, at version 2.7.0. It looks like this package development is not in progress, otherwise I think someone would have taken care of this problem until now.

streamtw commented 9 months ago

Sorry for late reply. I have reproduced this issue on my end. The error function may be deleted because I falsely thought it was a redundant function. I will release a fixed version today.

Samvdg commented 9 months ago

Awesome! Thank you!

streamtw commented 9 months ago

v2.7.1 has been released to fix this issue. Please run php artisan vendor:publish --force --tag=lfm_public and php artisan vendor:publish --force --tag=lfm_view after upgrading to v2.7.1.

jayson-velasquez commented 8 months ago

in public/vendor/laravel-filemanager/js/lfm.js the file_path in window.SetUrl is empty. causing an error