UniSharp / laravel-filemanager

Media gallery with CKEditor, TinyMCE and Summernote support. Built on Laravel file system.
https://unisharp.github.io/laravel-filemanager/
MIT License
2.09k stars 720 forks source link

Exif data for thumbnails is not copied #1182

Closed Samvdg closed 10 months ago

Samvdg commented 1 year ago

And provide the followings :

Basicly the title. I have images that are rotated via exif data instead of "physically" and the thumbnails of these images do not copy the rotation. However the original image does still have the rotation but this is most likely confusing for many

Samvdg commented 1 year ago

I went back to working on this and found out it has to do with the Intervention/image package: https://github.com/Intervention/image/issues/1190

There is currently a PR open to fix this however it seems the intervention package does not seem to be maintained anymore (just like this one seems abandoned, or at least the maintainers take a while with responding) https://github.com/Intervention/image/pull/1192

Samvdg commented 1 year ago

To circumvent this, you can change the 'should_create_thumbnails' in the config to false. Took me way too long to find this and am re-considering my 'career' as dev rn.

I searched through multiple file managers after giving up on this one like alexusmai's laravel filemanager and trippo's responsive filemanager but none were as simple as this one so i came back to it.

I can say however if you can edit css and need a bit more functionality than this package, i definitely recommend alexusmai's file manager (the package does have the same issue with thumbnails and exif data)(the filemanager doesn't really look amazing without content unless it's on fullscreen in my experience) but if you need more package functionality for example for routing than i recommend checking out trippo's responsive file manager. It takes a bit of setting up properly with laravel however there is a composer package out there by (i believe) someone called zippo.

Samvdg commented 1 year ago

I noticed that, when editing any image (which isn't very common for whyi use this filemanager) the exif data gets overwritten as well sadly. This is very very annoying

Samvdg commented 1 year ago

Eventually decided to just write my own middleware anyways specificly for rotating images. Also tried to extend the index view and removing the cropping and resize functionality which worked but using middleware looks nicer

Samvdg commented 10 months ago

HAPPY NEW YEAR AND HAPPY NEW IMAGICK UPDATE! This issue has been fixed accordingly since imagick version 3.0! Exif orientation tag now does NOT get lost! (It only took almost a full year hihi)