i try download a file from s3 but show the next error (The file "folder/share/file.zip" does not exist)

[SergioWiesner]

Please check the following instructions before submitting a bug :

• Make sure you are using the latest version.
• Make sure you read installation, integration, and upgrade document.

And provide the followings :

• Operating system : WINDOWS 10
• Laravel version : 6.0
• Package version :dev-master
• Steps to reproduce your issue :
  1. configure the package to work with s3.
  2. use the integration from "vendor/unisharp/laravel-filemanager/src/views/demo.blade.php"
  3. upload any file to share folder.
  4. try download the file from s3 with the button download file.
• Screenshots of browser console :

[2infinity-gh]

I have the same issue... very annoying

[daydevelops]

Has there been a solution for this?

[daydevelops]

The Problem

The download route calls an endpoint which uses the getDownload() method on the DownloadController which looks like this:

    public function getDownload()
    {
        $file = $this->lfm->setName(request('file'));

        if (!Storage::disk($this->helper->config('disk'))->exists($file->path('storage'))) {
            abort(404);
        }

        return response()->download($file->path('absolute'));
    }

response()->download() is a symphony component which eventually calls the native php function is_file() to determine if the file exists. This obviously does not check which disk you are using, so anything other than local will fail.

A Solution

To get around this, I overrode the getDownload() method on the package controller. Here are my registered routes:

Route::group(['prefix' => 'laravel-filemanager', 'middleware' => ['web','auth','access-files','file-permissions']], function () {
    \UniSharp\LaravelFilemanager\Lfm::routes();
    // override download route
    Route::get('/download', [FileManagerController::class, 'download']);
});

And the new controller method:

<?php

namespace App\Http\Controllers;

use Illuminate\Support\Facades\Storage;
use UniSharp\LaravelFilemanager\Controllers\LfmController;

class FileManagerController extends LfmController
{
    public function download() {
        $file = $this->lfm->setName(request('file'));

        if (!Storage::disk($this->helper->config('disk'))->exists($file->path('storage'))) {
            abort(404);
        }

        return Storage::disk($this->helper->config('disk'))->download($file->path('storage'));
    }
}

[dorqa95]

Thank you so much, it's helped me out <3