search

UniStuttgart-VISUS / damast

Code for the DH project "Dhimmis & Muslims – Analysing Multireligious Spaces in the Medieval Muslim World" (VolkswagenFoundation)
MIT License
10 stars 1 forks source link

Tooltips with evidence count may be wrong (1 or 0 only) in qualitative timeline #118

Closed mfranke93 closed 2 years ago

mfranke93 commented 2 years ago

I have to check this later, but noticed it being off.

mfranke93 commented 2 years ago

This happens because the tooltip is generated in the UI thread, and uses the d3.stack information to arrive at the counts. For the qualitative mode, these are either 0 or 1...

mfranke93 commented 2 years ago

The quantitative information is all there, though, because of the way the qualitative information is derived from it here. It should be possible to extract it in the tooltip code here accordingly. To keep the code clean and not spread implicit assumptions in two places, it would be good to externalize the key generation code (religion ID plus "a" or "i", or confidence level plus "a" or "i") (here, here, here, here) to a function. This should have happened earlier anyways.