search

UniStuttgart-VISUS / damast

Code for the DH project "Dhimmis & Muslims – Analysing Multireligious Spaces in the Medieval Muslim World" (VolkswagenFoundation)
MIT License
10 stars 1 forks source link

add new screenshots #138

Closed tutebatti closed 2 years ago

tutebatti commented 2 years ago

If minor differences in resolution and content (timeline mode in full-visualization) are ok, we would be good to go with this.

mfranke93 commented 2 years ago

We do not merge feature branches into main directly. Also, it would make sense to replace the screenshots from the start page as well while you're at it. So, I am going to close this, and ask you to make a new PR as follows:

  1. Of a branch that is up-to-date with release/v1.1.3
  2. PR back onto release/v1.1.3
  3. Including the screenshots of the start page that should change
  4. With the religion hierarchy screenshots as detailed above (same layout as before the PR)
tutebatti commented 2 years ago

Will do. However, I do not see any need for new screenshots for the start page. Map material is the same. No Shiite sub groups shown. Do you see anything there?

mfranke93 commented 2 years ago

Do you see anything there?

No, sorry. I thought that had a full screenshot, but in fact the Shi'ite subgroups are not visible (barely) in the partial one. So scratch that.