UniStuttgart-VISUS / damast

Code for the DH project "Dhimmis & Muslims – Analysing Multireligious Spaces in the Medieval Muslim World" (VolkswagenFoundation)
MIT License
10 stars 1 forks source link

add new screenshots #140

Closed tutebatti closed 2 years ago

tutebatti commented 2 years ago

as requested by @mfranke93 in #138

mfranke93 commented 2 years ago

I'm still not 100% happy with the new versions. Especially seeing them side by side with the replaced images, it is quite obvious that the map glyphs are much smaller in the new brushing and linking screenshots, and the gaps in the religion hierarchy much larger. I will add my own suggestion for you to approve.

tutebatti commented 2 years ago

Especially seeing them side by side with the replaced images, it is quite obvious that the map glyphs are much smaller in the new brushing and linking screenshots

This is correct. When making the screenshots it seemed to me as if my visualization skips the zoom level you apparently had. Or does the zoom level also depend on screen resolution? I have tried the "+" and "-" keys on my keyboard, the buttons in the visualization as well as my mouse wheel.

and the gaps in the religion hierarchy much larger

Sorry, didn't think that would be a problem.

mfranke93 commented 2 years ago

This is correct. When making the screenshots it seemed to me as if my visualization skips the zoom level you apparently had. Or does the zoom level also depend on screen resolution? I have tried the "+" and "-" keys on my keyboard, the buttons in the visualization as well as my mouse wheel.

The glyph size does not depend on zoom level. I did the screenshot with some browser zoom (150% I think), because screenshots are generally shown in smaller size. See my latest commit.

Scrolling and +/- only goes full zoom levels. By pressing shift and then clicking and dragging in the map, you can select a rectangle to zoom into, which allows for finer (quarter zoom level) zooming.

tutebatti commented 2 years ago

This does, in fact, look better. I hadn't thought about browser zoom. :see_no_evil:

mfranke93 commented 2 years ago

@tutebatti I changed the three images. If you have no objections, I would merge this.

tutebatti commented 2 years ago

Please do! And thanks!