search

UniStuttgart-VISUS / damast

Code for the DH project "Dhimmis & Muslims – Analysing Multireligious Spaces in the Medieval Muslim World" (VolkswagenFoundation)
MIT License
10 stars 1 forks source link

Bring out religions (and confidence?) in timeline #150

Closed tutebatti closed 2 years ago

tutebatti commented 2 years ago

When moving the mouse vertically in the timeline, would it be possible to bring out the religion over the bar of which one is currently hovering? The feedback was that the broad scale of different colors is not easily matched comparing the timeline with the overview in the religion view.

A possible alternative is labeling the bars at the beginning of the timeline. That only works in qualitative mode, however.

mfranke93 commented 2 years ago

My reply to this somehow disappeared...

So again: Yes, that is a good idea, and should not be too much development effort.

mfranke93 commented 2 years ago

I implemented a first version. This considers the closest category vertically (important for situations with many thin strips), but with a cutoff distance. However, if the closest category is empty (e.g., religion has no evidence in that year) nothing is highlighted (see first and third screenshot, cursor over an area with no data). It works for qualitative and quantitative modes, and for religion and confidence mode. Let me know whether the current behavior and highlighting are okay, based on the screenshots below (unfortunately they don't show the cursor, but it should be fine).

image image image image image image image image

tutebatti commented 2 years ago

Looks great, I'd say! :+1:

mfranke93 commented 2 years ago

Alright, I'll merge it then :)

tutebatti commented 2 years ago

Can this be closed?

mfranke93 commented 2 years ago

Can this be closed?

image

mfranke93 commented 1 year ago

You mean in the tooltip, right? Yes, I have thought about doing that as well, it should not be a large issue to add.

tutebatti commented 1 year ago

You implemented this already, haven't you? :)

mfranke93 commented 1 year ago

You mean in the tooltip, right? Yes, I have thought about doing that as well, it should not be a large issue to add.

That comment via e-mail took a five-month detour somehow... This was what I meant in https://github.com/UniStuttgart-VISUS/damast/issues/150#issuecomment-1127717138 by "reply disappeared".