Closed mfranke93 closed 1 year ago
(request review)
Changes requested:
release/v1.2.0
branch into fix/issue-196-197
firstCHANGELOG
accordingly(request review with changes)
Please change the formulation in the CHANGELOG
: Split up the sentence regarding issue #196, and clarify "(forks)" better.
(request review with changes)
(approve changes)
Note
This is a somewhat staged pull request. I (@mfranke93) am both the pull-requestee and owner of the fork, and the reviewer. The purpose is to showcase how to submit a pull request to this repository, and what review steps might occur.
Since I cannot be assigned as an actual reviewer on my own PR, I will have to put the review requirements as ordinary messages.
Actual Message
deploy.sh
to check for empty version strings that would lead to an error withdocker build
(UniStuttgart-VISUS/damast#196). In this case, a detailed error message is shown, suggesting to fetch upstream tags.README.md
to include a note on fetching upstream tags in forked repositories fordeploy.sh
to work (UniStuttgart-VISUS/damast#196).docs/postgres/Makefile
and, by extension,make prod
to build all dependencies first (UniStuttgart-VISUS/damast#197).