UniStuttgart-VISUS / damast

Code for the DH project "Dhimmis & Muslims – Analysing Multireligious Spaces in the Medieval Muslim World" (VolkswagenFoundation)
MIT License
10 stars 1 forks source link

fixes for issues 196 and 197 #198

Closed mfranke93 closed 1 year ago

mfranke93 commented 1 year ago

Note

This is a somewhat staged pull request. I (@mfranke93) am both the pull-requestee and owner of the fork, and the reviewer. The purpose is to showcase how to submit a pull request to this repository, and what review steps might occur.

Since I cannot be assigned as an actual reviewer on my own PR, I will have to put the review requirements as ordinary messages.

Actual Message

mfranke93 commented 1 year ago

Fork Owner

(request review)

mfranke93 commented 1 year ago

Reviewer

Changes requested:

mfranke93 commented 1 year ago

Fork Owner

(request review with changes)

mfranke93 commented 1 year ago

Reviewer

Please change the formulation in the CHANGELOG: Split up the sentence regarding issue #196, and clarify "(forks)" better.

mfranke93 commented 1 year ago

Fork Owner

(request review with changes)

mfranke93 commented 1 year ago

Reviewer

(approve changes)