search

UniStuttgart-VISUS / damast

Code for the DH project "Dhimmis & Muslims – Analysing Multireligious Spaces in the Medieval Muslim World" (VolkswagenFoundation)
MIT License
10 stars 1 forks source link

Do not allow entity rows in creation to be selected in the GeoDB editor #204

Closed mfranke93 closed 1 year ago

mfranke93 commented 1 year ago

From server logs:

1.2.3.4 - experimental/v1.2.0 [2023-07-14T12:54:42.365116+02:00] "GET /rest/place/-4/alternative-name/all HTTP/1.0" 404 3774 "https://www2.visus.uni-stuttgart.de/damast/testing/GeoDB-Editor/places" "UA: modern Firefox" "root-app"
1.2.3.4 - experimental/v1.2.0 [2023-07-14T12:54:42.371249+02:00] "GET /rest/place/-4/evidence-ids HTTP/1.0" 404 3766 "https://www2.visus.uni-stuttgart.de/damast/testing/GeoDB-Editor/places" "UA: modern Firefox" "root-app"
1.2.3.4 - experimental/v1.2.0 [2023-07-14T12:54:42.377686+02:00] "GET /rest/place/-4/external-uri-list HTTP/1.0" 404 3771 "https://www2.visus.uni-stuttgart.de/damast/testing/GeoDB-Editor/places" "UA: modern Firefox" "root-app"
1.2.3.4 - experimental/v1.2.0 [2023-07-14T12:54:46.974358+02:00] "PUT /rest/place/0 HTTP/1.0" 201 21 "https://www2.visus.uni-stuttgart.de/damast/testing/GeoDB-Editor/places" "UA: modern Firefox" "rest-api.place"
1.2.3.4 - experimental/v1.2.0 [2023-07-14T12:40:17.621325+02:00] "GET /rest/place/-1/evidence-ids HTTP/1.0" 404 3766 "https://www2.visus.uni-stuttgart.de/damast/testing/GeoDB-Editor/places" "UA: modern Firefox" "root-app"
1.2.3.4 - experimental/v1.2.0 [2023-07-14T12:40:17.628088+02:00] "GET /rest/place/-1/alternative-name/all HTTP/1.0" 404 3774 "https://www2.visus.uni-stuttgart.de/damast/testing/GeoDB-Editor/places" "UA: modern Firefox" "root-app"
1.2.3.4 - experimental/v1.2.0 [2023-07-14T12:40:17.634305+02:00] "GET /rest/place/-1/external-uri-list HTTP/1.0" 404 3771 "https://www2.visus.uni-stuttgart.de/damast/testing/GeoDB-Editor/places" "UA: modern Firefox" "root-app"
1.2.3.4 - experimental/v1.2.0 [2023-07-14T12:40:31.859823+02:00] "GET /rest/place/847/evidence-ids HTTP/1.0" 200 7 "https://www2.visus.uni-stuttgart.de/damast/testing/GeoDB-Editor/places" "UA: modern Firefox" "rest-api.place"
1.2.3.4 - experimental/v1.2.0 [2023-07-14T12:40:31.866530+02:00] "GET /rest/place/847/alternative-name/all HTTP/1.0" 200 108 "https://www2.visus.uni-stuttgart.de/damast/testing/GeoDB-Editor/places" "UA: modern Firefox" "rest-api.place"
1.2.3.4 - experimental/v1.2.0 [2023-07-14T12:40:31.872834+02:00] "GET /rest/place/847/external-uri-list HTTP/1.0" 200 7 "https://www2.visus.uni-stuttgart.de/damast/testing/GeoDB-Editor/places" "UA: modern Firefox" "rest-api.place.uri-list"
1.2.3.4 - experimental/v1.2.0 [2023-07-14T12:40:39.846933+02:00] "GET /rest/place/-1/evidence-ids HTTP/1.0" 404 3766 "https://www2.visus.uni-stuttgart.de/damast/testing/GeoDB-Editor/places" "UA: modern Firefox" "root-app"
1.2.3.4 - experimental/v1.2.0 [2023-07-14T12:40:39.854756+02:00] "GET /rest/place/-1/alternative-name/all HTTP/1.0" 404 3774 "https://www2.visus.uni-stuttgart.de/damast/testing/GeoDB-Editor/places" "UA: modern Firefox" "root-app"
1.2.3.4 - experimental/v1.2.0 [2023-07-14T12:40:39.881051+02:00] "GET /rest/place/-1/external-uri-list HTTP/1.0" 404 3771 "https://www2.visus.uni-stuttgart.de/damast/testing/GeoDB-Editor/places" "UA: modern Firefox" "root-app"
1.2.3.4 - experimental/v1.2.0 [2023-07-14T12:41:45.599348+02:00] "PUT /rest/place/0 HTTP/1.0" 201 21 "https://www2.visus.uni-stuttgart.de/damast/testing/GeoDB-Editor/places" "UA: modern Firefox" "rest-api.place"

Probable cause: dispatch might be too early here.

mfranke93 commented 1 year ago

This one (probably evidence creation) looks even worse, with duplicates:

1.2.3.4 - experimental/v1.2.0 [2023-07-14T13:57:31.235130+02:00] "PUT /rest/place-instance/0 HTTP/1.0" 201 32 "https://www2.visus.uni-stuttgart.de/damast/testing/GeoDB-Editor/places" "UA: modern Firefox" "rest-api.place-instance"
1.2.3.4 - experimental/v1.2.0 [2023-07-14T13:57:31.268255+02:00] "PUT /rest/religion-instance/0 HTTP/1.0" 201 35 "https://www2.visus.uni-stuttgart.de/damast/testing/GeoDB-Editor/places" "UA: modern Firefox" "rest-api.religion-instance"
1.2.3.4 - experimental/v1.2.0 [2023-07-14T13:57:31.310040+02:00] "PUT /rest/time-group/0 HTTP/1.0" 201 28 "https://www2.visus.uni-stuttgart.de/damast/testing/GeoDB-Editor/places" "UA: modern Firefox" "rest-api.time"
1.2.3.4 - experimental/v1.2.0 [2023-07-14T13:57:31.333700+02:00] "PUT /rest/person-instance/0 HTTP/1.0" 409 75 "https://www2.visus.uni-stuttgart.de/damast/testing/GeoDB-Editor/places" "UA: modern Firefox" "rest-api.person-instance"
1.2.3.4 - experimental/v1.2.0 [2023-07-14T13:57:41.878499+02:00] "PUT /rest/place-instance/0 HTTP/1.0" 201 32 "https://www2.visus.uni-stuttgart.de/damast/testing/GeoDB-Editor/places" "UA: modern Firefox" "rest-api.place-instance"
1.2.3.4 - experimental/v1.2.0 [2023-07-14T13:57:41.898997+02:00] "PUT /rest/religion-instance/0 HTTP/1.0" 201 35 "https://www2.visus.uni-stuttgart.de/damast/testing/GeoDB-Editor/places" "UA: modern Firefox" "rest-api.religion-instance"
1.2.3.4 - experimental/v1.2.0 [2023-07-14T13:57:41.923995+02:00] "PUT /rest/time-group/0 HTTP/1.0" 201 28 "https://www2.visus.uni-stuttgart.de/damast/testing/GeoDB-Editor/places" "UA: modern Firefox" "rest-api.time"
1.2.3.4 - experimental/v1.2.0 [2023-07-14T13:57:41.929931+02:00] "PUT /rest/person-instance/0 HTTP/1.0" 409 75 "https://www2.visus.uni-stuttgart.de/damast/testing/GeoDB-Editor/places" "UA: modern Firefox" "rest-api.person-instance"
1.2.3.4 - experimental/v1.2.0 [2023-07-14T13:58:42.575846+02:00] "PUT /rest/place-instance/0 HTTP/1.0" 201 32 "https://www2.visus.uni-stuttgart.de/damast/testing/GeoDB-Editor/places" "UA: modern Firefox" "rest-api.place-instance"
1.2.3.4 - experimental/v1.2.0 [2023-07-14T13:58:42.618692+02:00] "PUT /rest/time-group/0 HTTP/1.0" 201 28 "https://www2.visus.uni-stuttgart.de/damast/testing/GeoDB-Editor/places" "UA: modern Firefox" "rest-api.time"
1.2.3.4 - experimental/v1.2.0 [2023-07-14T13:58:42.643882+02:00] "PUT /rest/religion-instance/0 HTTP/1.0" 201 35 "https://www2.visus.uni-stuttgart.de/damast/testing/GeoDB-Editor/places" "UA: modern Firefox" "rest-api.religion-instance"
1.2.3.4 - experimental/v1.2.0 [2023-07-14T13:58:42.650038+02:00] "PUT /rest/person-instance/0 HTTP/1.0" 409 75 "https://www2.visus.uni-stuttgart.de/damast/testing/GeoDB-Editor/places" "UA: modern Firefox" "rest-api.person-instance"
1.2.3.4 - experimental/v1.2.0 [2023-07-14T13:59:07.221463+02:00] "PUT /rest/place-instance/0 HTTP/1.0" 201 32 "https://www2.visus.uni-stuttgart.de/damast/testing/GeoDB-Editor/places" "UA: modern Firefox" "rest-api.place-instance"
1.2.3.4 - experimental/v1.2.0 [2023-07-14T13:59:07.247375+02:00] "PUT /rest/time-group/0 HTTP/1.0" 201 28 "https://www2.visus.uni-stuttgart.de/damast/testing/GeoDB-Editor/places" "UA: modern Firefox" "rest-api.time"
1.2.3.4 - experimental/v1.2.0 [2023-07-14T13:59:07.272382+02:00] "PUT /rest/religion-instance/0 HTTP/1.0" 201 35 "https://www2.visus.uni-stuttgart.de/damast/testing/GeoDB-Editor/places" "UA: modern Firefox" "rest-api.religion-instance"
1.2.3.4 - experimental/v1.2.0 [2023-07-14T13:59:07.278216+02:00] "PUT /rest/person-instance/0 HTTP/1.0" 409 75 "https://www2.visus.uni-stuttgart.de/damast/testing/GeoDB-Editor/places" "UA: modern Firefox" "rest-api.person-instance"
1.2.3.4 - experimental/v1.2.0 [2023-07-14T13:59:10.841221+02:00] "PUT /rest/place-instance/0 HTTP/1.0" 201 32 "https://www2.visus.uni-stuttgart.de/damast/testing/GeoDB-Editor/places" "UA: modern Firefox" "rest-api.place-instance"
1.2.3.4 - experimental/v1.2.0 [2023-07-14T13:59:10.866006+02:00] "PUT /rest/religion-instance/0 HTTP/1.0" 201 35 "https://www2.visus.uni-stuttgart.de/damast/testing/GeoDB-Editor/places" "UA: modern Firefox" "rest-api.religion-instance"
1.2.3.4 - experimental/v1.2.0 [2023-07-14T13:59:10.891144+02:00] "PUT /rest/time-group/0 HTTP/1.0" 201 28 "https://www2.visus.uni-stuttgart.de/damast/testing/GeoDB-Editor/places" "UA: modern Firefox" "rest-api.time"
1.2.3.4 - experimental/v1.2.0 [2023-07-14T13:59:10.897106+02:00] "PUT /rest/person-instance/0 HTTP/1.0" 409 75 "https://www2.visus.uni-stuttgart.de/damast/testing/GeoDB-Editor/places" "UA: modern Firefox" "rest-api.person-instance"
1.2.3.4 - experimental/v1.2.0 [2023-07-14T13:59:16.442107+02:00] "PUT /rest/place-instance/0 HTTP/1.0" 201 32 "https://www2.visus.uni-stuttgart.de/damast/testing/GeoDB-Editor/places" "UA: modern Firefox" "rest-api.place-instance"
1.2.3.4 - experimental/v1.2.0 [2023-07-14T13:59:16.466969+02:00] "PUT /rest/religion-instance/0 HTTP/1.0" 201 35 "https://www2.visus.uni-stuttgart.de/damast/testing/GeoDB-Editor/places" "UA: modern Firefox" "rest-api.religion-instance"
1.2.3.4 - experimental/v1.2.0 [2023-07-14T13:59:16.492029+02:00] "PUT /rest/time-group/0 HTTP/1.0" 201 28 "https://www2.visus.uni-stuttgart.de/damast/testing/GeoDB-Editor/places" "UA: modern Firefox" "rest-api.time"
1.2.3.4 - experimental/v1.2.0 [2023-07-14T13:59:16.498444+02:00] "PUT /rest/person-instance/0 HTTP/1.0" 409 75 "https://www2.visus.uni-stuttgart.de/damast/testing/GeoDB-Editor/places" "UA: modern Firefox" "rest-api.person-instance"
1.2.3.4 - experimental/v1.2.0 [2023-07-14T14:01:27.984931+02:00] "GET /rest/evidence/-1/source-instances HTTP/1.0" 404 3773 "https://www2.visus.uni-stuttgart.de/damast/testing/GeoDB-Editor/places" "UA: modern Firefox" "root-app"
mfranke93 commented 1 year ago

Entire server log (anonymized)

mfranke93 commented 1 year ago

Conclusion after some testing: this error occurs when selecting an entity row (first column) while it is being created. At that moment, it has a negative, non-existent ID. This should be an easy fix: disallow selecting rows that are currently being created.