UniStuttgart-VISUS / megamol

A cross-platform visualization prototyping framework
https://megamol.org/
BSD 3-Clause "New" or "Revised" License
49 stars 36 forks source link

GRIMRenderer broken #272

Closed reinago closed 5 years ago

reinago commented 5 years ago

Indeed the GRIMRenderer can still be faster than NGSphere if bricking is done properly, I observed 2x FPS for laser.big, but in the current state it's broken since the referenced shader snippets were renamed and possibly changed around a little bit when all the sphere shaders were combined into one.

For reference, the ISC_Demo_IceT tag has a fully working GRIM renderer, just capture the shaders from there and check what's broken.

This helps getting rid of the warnings, but I think I still mislinked some snippet:

$ git diff core/Shaders/mipdepth6.btf
diff --git a/core/Shaders/mipdepth6.btf b/core/Shaders/mipdepth6.btf
index bb4662034..7df6dd1fe 100644
--- a/core/Shaders/mipdepth6.btf
+++ b/core/Shaders/mipdepth6.btf
@@ -11,12 +11,12 @@
 #define DEFERRED_SHADING
 ]]>
     </snippet>
-    <snippet name="simplesphere::vertex::attributes" />
-    <snippet name="simplesphere::vertex::MainParams" />
-    <snippet name="simplesphere::vertex::posTrans" />
-    <snippet name="simplesphere::vertex::clippingPlane" />
+    <snippet name="simplesphere::vertex::Attributes" />
+    <snippet name="simplesphere::vertex::MainStart" />
+    <snippet name="simplesphere::vertex::PosTrans" />
+    <snippet name="simplesphere::vertex::ClippingPlane" />
     <snippet name="simplesphere::vertex::SphereTouchPlane" />
-    <snippet name="simplesphere::vertex::Output" />
+    <snippet name="simplesphere::vertex::PosOutput" />
     <snippet type="string">
       <![CDATA[
 }]]>
@@ -323,8 +323,8 @@ void main(void) {
 varying float pointSize;
 ]]>
     </snippet>
-    <snippet name="simplesphere::fragment::body1" />
-    <snippet name="simplesphere::fragment::out-depth" />
+    <snippet name="simplesphere::fragment::MainStart" />
+    <snippet name="simplesphere::fragment::OutDepth" />
     <snippet type="string">
       <![CDATA[
   gl_FragData[0] = vec4(color.rgb, 1.0);
braunms commented 5 years ago

Will be fixed in pull request #278.