Department Pages GWT and Funding Dept

[palpurdue]

Pull request for Department Changes.

[tomas-muller]

Departments page -- Major Issues

• Distribution Preference Priority is not populated and not being updated on the Add/Edit Department page
• The ability to edit External Manager Abbreviation, Name and Distribution Priority is not correctly handled
  • The abbreviation, name, and priority is not editable only when editing an existing department that is not externally managed and does not allow for a change
  • They should be editable for department that is externally managed (only the manager toggle should be disabled)
  • Any consequent editation have the fields disabled (even when adding a new department)
  • Examples (from woebegon data):
    1. LLR department has External Manager checked and disabled, but abbreviation, name, and dist priority are editable
    2. Instr department had External Manager unchecked and all External Manager fields and the dist priority are not editable (this is correct)
    3. After Instr department was opened, editing any other department or adding a new department has the fields disabled -- try to update LLR department and then create a new externally managed department
• External Id field on the Edit Department page does not populate (it always shows blank, even when the department has an external id filled in)

Departments page -- Minor Issues

• DepartmentsDataResponse: iCanUpdateData is not beeing used and it is not correctly set (see inline comments) (this was mentioned in one of the previous comments too)
• UpdateDepartmentBackend: do NOT call hibSession.close() in saveOrUpdate(...), see the inline comment
• when the External Manager toggle is unchecked, please hide or disable External Manager Abbreviation and Name (they are only editable when the department is marked as external)
• There are still a few texts that are not localizable (are hard-coded instead of using MESSAGES bundle)
  • E.g., the content of the Allow Required column

Classes page changes

• Instructional Offerings page got broken by the changes!! WebInstructionalOfferingTableBuilder.setVisibleColumns(...) calls setShowFundingDepartment(form.getFundingDepartment().booleanValue()) but getFundingDepartment() returns null
• please remove the unused changes in ClassSearchAction (created fetchFundingDepartment variable, commented out code using it -- see inline comments)
• ClassListForm: in the reset method, fundingDepartment is initialized two times (see inline comment)
• WebInstructionalOfferingTableBuilder: please remove the added commented out code (second addition of the Funding Department column header, see inline comment)
• classList.jsp: please remove the change (only a blank line was added)

Other

• please remove src/main/webapp/META-INF/MANIFEST.MF from the committed changes

Also, please take a look at the inline comments!