Evaluate using Travis for Windows builds

Unibeautify / unibeautify

One Beautifier to rule them all, One Beautifier to clean them, One Beautifier to bring them all and in the darkness sheen them

https://unibeautify.com/

MIT License

544 stars 41 forks source link

Evaluate using Travis for Windows builds #204

Open lassik opened 6 years ago

lassik commented 6 years ago

From the Travis CI blog: Windows is Available (Early Release) Oct 11, 2018

Found by @stevenzeck

stevenzeck commented 6 years ago

To Do:

[ ] Add windows to the os list
[ ] Don't download/configure CodeClimate or send test results when running Windows builds as it is not supported
[ ] Configure so all OS's use LF and not CRLF. When cloning a repo and checking out a commit, the linebreaks depend on the OS, so Windows builds will fail TSLint since it uses CRLF and not LF. I'm playing around by adding a .gitattributes file with * text=auto eol=lf.

stevenzeck commented 6 years ago

Seems to be working in beautifier-eslint:

lassik commented 6 years ago

Awesome 🎉 The eslint Windows builds seem to be red, but only because of the CRLF situation.

stevenzeck commented 6 years ago

It's red on the PR build, not the branch build.

lassik commented 6 years ago

What's different between them? The commit hash is the same.

stevenzeck commented 6 years ago

I'll try pushing everything as one commit and see if that makes a difference. Otherwise I think one is a standard commit while the other is a merge commit.

lassik commented 6 years ago

The outcome seems to be the same :/ I just had a weird incident too, where something worked in Travis in a branch but not in a PR: https://github.com/Unibeautify/beautifier-clang-format/pull/81

lassik commented 6 years ago

BTW, should Code Climate be run separately for each platform, or is it enough to run it on Linux only?

stevenzeck commented 6 years ago

It shouldn't matter. All it does it reports the coverage results of npm test (I think all repos use that command) from Travis to CodeClimate, not much overhead.

lassik commented 6 years ago

Ah, that makes sense. For reference, the Code Climate reporter is not available (pre-built) for Windows, only Linux and OSX: https://docs.codeclimate.com/v1.0/docs/configuring-test-coverage#section-locations-of-pre-built-binaries

stevenzeck commented 6 years ago

Yep, that's the second checkmark https://github.com/Unibeautify/unibeautify/issues/204#issuecomment-429361164

lassik commented 6 years ago

Sorry, missed that one.

Glavin001 commented 6 years ago

👍I would greatly prefer Travis CI to AppVeyor.

Let me know if you need anything from me. Sounds like you already have a plan and are making this a reality 🎉 ! Thanks!