search

Unicen-Tuari / bomberos

4 stars 13 forks source link

Add HTTP Tests to improve Code Coverage #225

Closed ignaciojonas closed 6 years ago

codecov[bot] commented 6 years ago

Codecov Report

Merging #225 into master will increase coverage by 12.75%. The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master     #225       +/-   ##
=============================================
+ Coverage      8.79%   21.54%   +12.75%     
  Complexity      354      354               
=============================================
  Files            38       38               
  Lines           978      984        +6     
=============================================
+ Hits             86      212      +126     
+ Misses          892      772      -120
Flag Coverage Δ Complexity Δ
#php 21.54% <100%> (+12.75%) 354 <0> (ø) :arrow_down:
Impacted Files Coverage Δ Complexity Δ
app/Http/Controllers/BomberoController.php 100% <100%> (+100%) 15 <0> (ø) :arrow_down:
app/Http/Controllers/VehiculoController.php 100% <100%> (+100%) 16 <0> (ø) :arrow_down:
app/Servicio.php 78.57% <0%> (+7.14%) 15% <0%> (ø) :arrow_down:
app/Bombero.php 42.37% <0%> (+13.55%) 30% <0%> (ø) :arrow_down:
app/Vehiculo.php 100% <0%> (+28.57%) 8% <0%> (ø) :arrow_down:
app/Http/Requests/BomberoRequest.php 88.88% <0%> (+88.88%) 6% <0%> (ø) :arrow_down:
app/Http/Requests/VehiculoRequest.php 92.3% <0%> (+92.3%) 6% <0%> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f1bb9f0...ec61e69. Read the comment docs.

ignaciojonas commented 6 years ago

@perezale La estuve nerdeando y le aumente un 20% el coverage 👍 Si podes mira el PR.