Unicen-Tuari / bomberos

4 stars 13 forks source link

Split nro_legajo into cuartel / legajo . Fixes #249 #252

Closed perezale closed 6 years ago

perezale commented 6 years ago

This issue involved several changes over the entire project.

Added migration. Updated Models, controllers, views, tests, seeders and factories.

codecov[bot] commented 6 years ago

Codecov Report

Merging #252 into master will decrease coverage by 0.28%. The diff coverage is 75%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #252      +/-   ##
============================================
- Coverage     23.65%   23.37%   -0.29%     
- Complexity      397      398       +1     
============================================
  Files            42       42              
  Lines          1082     1078       -4     
============================================
- Hits            256      252       -4     
  Misses          826      826
Flag Coverage Δ Complexity Δ
#php 23.37% <75%> (-0.29%) 398 <1> (+1)
Impacted Files Coverage Δ Complexity Δ
app/Http/Requests/BomberoRequest.php 83.33% <ø> (-5.56%) 6 <0> (ø)
app/Http/Controllers/PuntuacionController.php 0% <0%> (ø) 37 <0> (ø) :arrow_down:
app/Bombero.php 44.26% <100%> (+1.88%) 31 <1> (+1) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f34005f...5883917. Read the comment docs.