search

Unidata / IDV

The Integrated Data Viewer (IDV) from Unidata is a framework for analyzing and displaying geoscience data.
http://www.unidata.ucar.edu/software/idv/
Other
80 stars 37 forks source link

Set idv.capture.gif.useGlobalTable default to true #100

Closed jon4than closed 9 years ago

jon4than commented 9 years ago

Having it default to false can result in output that looks like (watch the color table in particular):

http://mcidas.ssec.wisc.edu/tmp/example_per_frame.gif

Having the property default to true:

http://mcidas.ssec.wisc.edu/tmp/example_all_frames.gif

donmurray commented 9 years ago

This should really be left to the user to decide whether it's true/false because it really depends on what you are capturing. For example, if you set it to true and then capture a set of visible images where the first image is very dark (i.e. near sunrise) you will get a very dark animation. I added this option and set the default to false just to handle that case. I think this needs to be looked into for a more permanent solution.

jon4than commented 9 years ago

I had been scratching my head wondering about the reasoning, so thanks for clearing that up! However, isn't the false default value negated by the following (from idv.properties)?

## Flag to use global color table for creating animated gifs
idv.capture.gif.useGlobalTable=true
donmurray commented 9 years ago

Sorry, I now see what you are trying to do. I suspect that it was initially false and I (or someone) got tired of having to change it in our own idv.properties, so it got added to idv.properties after the fact and ImageSequenceGrabber was never changed. (maybe do a blame on that line). Yes, it should be consistent whatever the default. However, it would still be nice to have something in the movie capture UI to allow the user to override it on the fly.

yuanho commented 9 years ago

Well, let us talk about this change in the coming telconf.

Yuan

On Thu, Sep 3, 2015 at 12:47 PM, Don Murray notifications@github.com wrote:

Sorry, I now see what you are trying to do. I suspect that it was initially false and I (or someone) got tired of having to change it in our own idv.properties, so it got added to idv.properties after the fact and ImageSequenceGrabber was never changed. (maybe do a blame on that line). Yes, it should be consistent whatever the default. However, it would still be nice to have something in the movie capture UI to allow the user to override it on the fly.

— Reply to this email directly or view it on GitHub https://github.com/Unidata/IDV/pull/100#issuecomment-137539844.

julienchastang commented 9 years ago

Closing.

yuanho commented 9 years ago

wait for a new pull request