search

Unidata / IDV

The Integrated Data Viewer (IDV) from Unidata is a framework for analyzing and displaying geoscience data.
http://www.unidata.ucar.edu/software/idv/
Other
80 stars 37 forks source link

Allow user to control use of global GIF palette. #102

Closed jon4than closed 9 years ago

jon4than commented 9 years ago

This adds a checkbox to the "Save" dialog created by the "Movie Capture" window. The state of the checkbox represents the value of idv.capture.gif.useGlobalTable.

The default value of idv.capture.gif.useGlobalTable is true.

You may want to change the tooltip text; we decided to err on the "descriptive" side of things. Java has apparently decided that tooltips should be "dismissed" after 4 seconds, and this totally-not-user-hostile feature can make reading said tooltip somewhat challenging. The dismissal feature can be effectively disabled by doing something like the following:

import javax.swing.ToolTipManager;
...
ToolTipManager.sharedInstance().setDismissDelay(Integer.MAX_VALUE);
...

Example with idv.capture.gif.useGlobalTable set to false: Not using global GIF palette

Example with idv.capture.gif.useGlobalTable set to true: Using global GIF palette

This is a refinement of #100.

donmurray commented 9 years ago

I would change the UI to read "Use constant color palette for GIF" instead of "Use 'global' GIF color palette". For the tooltip, I would say "varying color" animations instead of "low light". It's a long tooltip, but the explanation is necessary. Also add something to the User Guide.

jon4than commented 9 years ago

Done!

donmurray commented 9 years ago

So I guess the only other thing would be whether this should set the global property from this dialog, or whether the global setting should be done from the User Preferences and this would only override it temporarily.

jon4than commented 9 years ago

Yeah, I wasn't sure about that myself--I'll defer to whatever is decided.

yuanho commented 9 years ago

Jon, I played your changes a little deeper this afternoon. In the current IDV, this value is set to be true in the idv.properties file, so if I un check the checkbox in your change doesn't make any difference. I agree with Don, we need to add this to the user preference first, probably somewhere under View tab, then do what you have here.

Yuan

yuanho commented 9 years ago

Ok, it is my fault. It does change the result. So I will merge this pull request. And, it will be good to add the user preference interface.

Thanks for the contribution.

Yuan