search

Unidata / IDV

The Integrated Data Viewer (IDV) from Unidata is a framework for analyzing and displaying geoscience data.
http://www.unidata.ucar.edu/software/idv/
Other
80 stars 37 forks source link

Rework layout and bug fix: label interval 0 means no labels [1587] #59

Closed tommyjasmin closed 10 years ago

tommyjasmin commented 10 years ago

Julien & Co., here is the original contour label frequency mod. Does require you to be fairly current on VisAD.

julienchastang commented 10 years ago

I think there may be a problem here. When I select a label interval of 0 and click OK, there are indeed no labels, but when I try to change this value again, it mysteriously defaults to 2 and changing it has no effect. Is this what you are seeing? I have noticed this behavior on both master and the contourlabels branch.

tommyjasmin commented 10 years ago

Julien - this one is working fine for me and I just brought in current IDV master. Anything funny in the logs? How current is your visad.jar?

tommyjasmin commented 10 years ago

Wait Julien - I do see some behavior differences between "Apply" and "Ok".
You may be right, hold tight until I investigate, sorry...

tommyjasmin commented 10 years ago

Julien - yes, problem here, I will fix it, stay tuned.

tommyjasmin commented 10 years ago

Ok, Julien, bugs are fixed. Was able to just tweak the current pull request, probably should have done that with the other one, sorry for any confusion.

julienchastang commented 10 years ago

I am still seeing the same (or similar problem). Once I have chosen a "Label Every Nth Line" of 0 and click OK, I can never change it to any other value. Are you seeing the same?

tommyjasmin commented 10 years ago

Julien - yes, I agree the behavior is confusing. What's happening is setting the value to zero has (for now), a secondary effect of UNCHECKING the checkbox to enable labeling. You have to click the Labels checkbox to turn labeling back on.

Now... Bob and I looked at this together today and agree this behavior is just too confusing. I think you will be ok with the idea we came up with to resolve it, which is:

  1. Make the minimum on the spinner 1 instead of 0
  2. The only way to turn labeling off is to uncheck the Labels checkbox

I'm not sure why this didn't occur to us earlier, but I think with these changes this UI will finally make sense. Should I go ahead with this?

tommyjasmin commented 10 years ago

Ok Julien, let's try once more. Modified as per previous comment. FYI I may have to miss the telecon tomorrow, sorry bout that.

julienchastang commented 10 years ago

Merged. I had a couple of problems with git so just confirm things are working as expected on your end. Thanks.

tommyjasmin commented 10 years ago

Thanks for staying on this Julien, we'll verify everything is as expected. Sorry I missed the call - stepdaughter 21st birthday today.