search

Unidata / IDV

The Integrated Data Viewer (IDV) from Unidata is a framework for analyzing and displaying geoscience data.
http://www.unidata.ucar.edu/software/idv/
Other
80 stars 37 forks source link

Add a method for clearing auto display args. #69

Closed jon4than closed 10 years ago

jon4than commented 10 years ago

Hi everyone!

This change is pretty straightforward–all it does is allow code outside of ucar.unidata.idv to clear out initParams and initDisplays. I thought about simply making those fields protected, but this approach seems a little more tidy.

Jon

donmurray commented 10 years ago

Jon- What is the problem you are trying to solve? It seems like these are used for handling command line arguments. If you don't pass any args in, they are empty anyway.

Don

jon4than commented 10 years ago

Hi Don,

I was looking into removing the (async) loading of http://www.unidata.ucar.edu/software/idv/resources/bundles.xml in IntegratedDataViewer's initDone method. The most straightforward approach was to simply never call super.initDone() from McV's initDone…but I was concerned about what might happen in IntegratedDataViewer's loadDataSource if the autodisplay args haven't been cleared out.

…and then I started thinking it would be nice to make ArgsManager a little more extension-friendly, and that's how we find ourselves here! But having thought about it a little more, the pull request as-is doesn't exactly do a whole lot to make things "extension-friendly".

Maybe simply making the fields protected, or adding public (or protected) getters/setters would be better?

jon4than commented 10 years ago

Closing per telecon discussion.