Unidata / LDM

The Unidata Local Data Manager (LDM) system includes network client and server programs designed for event-driven data distribution, and is the fundamental component of the Unidata Internet Data Distribution (IDD) system.
http://www.unidata.ucar.edu/software/ldm
Other
43 stars 27 forks source link

NWS feature rollup 8/23/2016 #54

Closed brian-m-rapp closed 7 years ago

brian-m-rapp commented 7 years ago

New NWS features:

Code has been scanned with Coverity.

semmerson commented 7 years ago

Working on it.

semmerson commented 7 years ago

@brian-m-rapp I notice that productMaker.c defines RETRANS_SUPPORT on line 6. This would seem to have consequences for non-NOAA users of NOAAPort: it would cause them to execute a lot of irrelevant code. Is that code guaranteed to work for non-NOAA sites? Is it meaningful for non-NOAA sites to execute that code?

brian-m-rapp commented 7 years ago

whoops...I put that in there temporarily and forgot to take it out once I was done. That definitely should not be there. Good catch.

Brian

On Tue, Sep 13, 2016 at 2:40 PM, Steven Emmerson notifications@github.com wrote:

@brian-m-rapp https://github.com/brian-m-rapp I notice that productMaker.c defines RETRANS_SUPPORT on line 6. This would seem to have consequences for non-NOAA users of NOAAPort: it would cause them to execute a lot of irrelevant code. Is that code guaranteed to work for non-NOAA sites? Is it meaningful for non-NOAA sites to execute that code?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Unidata/LDM/pull/54#issuecomment-246780712, or mute the thread https://github.com/notifications/unsubscribe-auth/ADr8J8Eyzbt5hOJx1nPGgs1L1NIST4Dzks5qpu4YgaJpZM4JrWxq .

semmerson commented 7 years ago

Merged most modifications (some mods were obviated by subsequent changes).

brian-m-rapp commented 7 years ago

Excellent, Thanks Steve!

Brian

On 09/13/2016 07:06 PM, Steven Emmerson wrote:

Merged most modifications (some mods were obviated by subsequent changes).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Unidata/LDM/pull/54#issuecomment-246854249, or mute the thread https://github.com/notifications/unsubscribe-auth/ADr8J26iyTvbdYRPMFEjdt2-YYMccWBOks5qpyxegaJpZM4JrWxq.