Unidata / MetPy

MetPy is a collection of tools in Python for reading, visualizing and performing calculations with weather data.
https://unidata.github.io/MetPy/
BSD 3-Clause "New" or "Revised" License
1.26k stars 415 forks source link

Add AWIPS colortables #721

Open dopplershift opened 6 years ago

dopplershift commented 6 years ago

AWIPS has a ton of color tables that would probably be nice to have. What we need is:

  1. Add code to convert AWIPS XML table to our format (like we have with convert_gempak_table)
  2. Convert a ton of tables:

We may need to implement support in the registry to scan recursively for tables, adding the subdirectories as namespaces (?) to avoid having 1000's of color tables in one flat directory. So for instance, awips/sat/WV/Dry_Yellow.tbl is available from the registry as `registry.get_colortable('awips.sat.WV.Dry_Yellow').

eliteuser26 commented 6 years ago

@dopplershift What is the purpose of the registry you have mentionned in the details?

Should the directory be passed on to the AWIPS converter or be extracted from the colormaps in the Unidata directories? Maybe it doesn't matter that much but how is the directory name defined in the script based on the colormaps directories?

Do you have a specific order for the red, green and blue colors and what happens to the alpha number?

I know this is a lot of questions but it can created in different ways. I would like to be steered in the right direction based on the directory structure. Open to comments/suggestions.

jrleeman commented 6 years ago

Hi @eliteuser26 - We're currently talking about how to handle the color tables and thinking we might be changing how things are done a bit. That being said, this might be a good one to hold off on a for a bit.

In the current incarnation all of those tables would live in MetPy with a converter to load them into simple RGB maps. We're thinking of a more clever way to also encode the common bounds, uses, etc.

eliteuser26 commented 6 years ago

Sounds good to me. I will wait on this issue so you can figure that one out.

Claude Dicaire.

On Feb 15, 2018 16:47, "John Leeman" notifications@github.com wrote:

Hi @eliteuser26 https://github.com/eliteuser26 - We're currently talking about how to handle the color tables and thinking we might be changing how things are done a bit. That being said, this might be a good one to hold off on a for a bit.

In the current incarnation all of those tables would live in MetPy with a converter to load them into simple RGB maps. We're thinking of a more clever way to also encode the common bounds, uses, etc.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Unidata/MetPy/issues/721#issuecomment-366072405, or mute the thread https://github.com/notifications/unsubscribe-auth/Aeg_MfcZClD3YFS2917pPxKBAz72GjTuks5tVKX0gaJpZM4Ru2eD .

blaylockbk commented 6 years ago

I made this based on a PowerPoint by Joseph Moore about NWS standard color curves... https://github.com/blaylockbk/pyBKB_v2/blob/master/demos/National_Weather_Service_Standard_Color_Curves.ipynb (I put this link in another issue, but it looks like this one has more discussion)