Unidata / UDUNITS-2

API and utility for arithmetic manipulation of units of physical quantities
http://www.unidata.ucar.edu/software/udunits
Other
62 stars 36 forks source link

Fix Windows builds #49

Closed ocefpaf closed 7 years ago

ocefpaf commented 7 years ago

The AppVeyor failure is related to a conda-build change where the manually copied xml are not available in the test phase. I am downgrading conda-build to 2.1.1 is for now. I'll unpin once the issue is resolved upstream.

However, that revealed a failure when building for vc9 that I believe is legit. Probably due to a change in the cmake configure files:

(C:\Miniconda-x64\conda-bld\conda.recipe_1495810967610\_b_env) C:\Miniconda-x64\conda-bld\conda.recipe_1495810967610\work>cmake -G "NMake Makefiles"       -D EXPAT_INCLUDE_DIR=C:\Miniconda-x64\conda-bld\conda.recipe_1495810967610\_b_env\Library\include\expat.h       -D CMAKE_INSTALL_PREFIX=C:\Miniconda-x64\conda-bld\conda.recipe_1495810967610\_b_env\Library       -D CMAKE_BUILD_TYPE=Release       C:\Miniconda-x64\conda-bld\conda.recipe_1495810967610\work 
-- The C compiler identification is unknown
CMake Error at CMakeLists.txt:1 (PROJECT):
  The CMAKE_C_COMPILER:
    cl
  is not a full path and was not found in the PATH.
  To use the NMake generator with Visual C++, cmake must be run from a shell
  that can use the compiler cl from the command line.  This environment is
  unable to invoke the cl compiler.  To fix this problem, run cmake from the
  Visual Studio Command Prompt (vcvarsall.bat).
  Tell CMake where to find the compiler by setting either the environment
  variable "CC" or the CMake cache entry CMAKE_C_COMPILER to the full path to
  the compiler, or to the compiler name if it is in the PATH.
-- Configuring incomplete, errors occurred!
See also "C:/Miniconda-x64/conda-bld/conda.recipe_1495810967610/work/CMakeFiles/CMakeOutput.log".
See also "C:/Miniconda-x64/conda-bld/conda.recipe_1495810967610/work/CMakeFiles/CMakeError.log"
semmerson commented 7 years ago

I merged your PR.

One of the Appveyer builds is still failing, however. See https://ci.appveyor.com/project/StevenEmmerson/udunits-2/build/1.0.19.

ocefpaf commented 7 years ago

Yep. See my comment on the PR.

semmerson commented 7 years ago

Can you fix it?

ocefpaf commented 7 years ago

Can you fix it?

Not right now. I need to bisect the code to find out the change that introduced the error. I can take a look at this once I get back home in a week or so.