search

Unidata / UDUNITS-2

API and utility for arithmetic manipulation of units of physical quantities
http://www.unidata.ucar.edu/software/udunits
Other
62 stars 36 forks source link

Use the shared library to locate the default xml #63

Closed mingwandroid closed 6 years ago

mingwandroid commented 6 years ago

Reference: https://github.com/conda-forge/udunits2-feedstock/issues/18

Here, the Anaconda Distribution and conda-forge build their software to be relocatable (so that, for example it can be installed in the user's home directory). This conflicts with baking any paths in at compilation time so here I use features of the underlying OSes to allow relative re-location to take place.

ocefpaf commented 6 years ago

@semmerson it would be nice to get this merged. It should fix the Windows issues we are experiencing. (I'll update AppVeyor here so we can test it.)

rsignell-usgs commented 6 years ago

@semmerson or @WardF , it would be great to fix the Windows issues with this PR!

semmerson commented 6 years ago

I intend to look at this later today or tomorrow.

mingwandroid commented 6 years ago

Thanks!

mingwandroid commented 6 years ago

Ping on this @semmerson, anything I need to change?

semmerson commented 6 years ago

@mingwandroid Can you change the number of hours in a week? That would help. :-)

I'll try to get to it today.

rsignell-usgs commented 6 years ago

@semmerson would be greatly appreciated!

semmerson commented 6 years ago

@mingwandroid The test of the commit by Appveyor failed. I'm not an Appveyor expert. Do you know what the log file is saying? log.txt

ocefpaf commented 6 years ago

@semmerson that is unrelated to this PR. I'll fix AppVeyor in a moment.

Although we are getting a real failure when building the package. See https://ci.appveyor.com/project/conda-forge/udunits2-feedstock/build/1.0.69