search

Unidata / gempak

Analysis and product generation for meteorological data.
BSD 3-Clause "New" or "Revised" License
69 stars 30 forks source link

Modify tables to add NIDS Super High Res 0.5 deg reflectivity #71

Closed pjpokran closed 2 years ago

pjpokran commented 2 years ago

These are the changes I made to allow nex2gini to create composites using the new N0B super high res reflectivity (used to use N0Q)

mzuranski commented 2 years ago

This is more complete than what I had done (#67) and I'm wondering if these changes to nex2gini.tbl will fix my issue with the color bar labels as I missed that file.

akrherz commented 2 years ago

I am on the case today about this and have an issue #72 tracking it. Thanks for the swing at this @pjpokran, I think a bit of wordsmithing is needed yet... The initial worry is that there are hard coded GEMPAK array size limits that will bomb out with these files. Good luck all with this effort!

akrherz commented 2 years ago

Hi @pjpokran, so there's one big issue here with your PR, you made it from your local main branch, which makes it somewhat tough to manage the lifecycle of your pull request. The best practice is to generally first create a new branch dedicated to your PR, commit your code changes to that branch and then push that branch up to github and create the pull request from it.

I'm gonna create a new PR #73 with your commits cherry-picked and then iterate some on it. Thanks for getting this ball rolling!