search

Unidata / gempak

Analysis and product generation for meteorological data.
BSD 3-Clause "New" or "Revised" License
69 stars 30 forks source link

set NAWIPS to path holding Gemenviron by default #85

Closed akrherz closed 2 years ago

akrherz commented 2 years ago

see #57

akrherz commented 2 years ago

Any bash/csh experts out there? Please review this PR and chime in with your opinions!

mzuranski commented 2 years ago

@akrherz FYI I also opened #80 to isolate this topic from the rest of #57

sgdecker commented 2 years ago

I know in bash it can be notoriously tricky to handle all the edge cases, but off hand I don't see why the cd -- and && pwd parts are needed. In other words, why isn't dirname good enough? But I am no bash expert.

akrherz commented 2 years ago

Yeah @sgdecker, that's a fair question and perhaps I am over-engineering here. I am worried about symlinks being used, but perhaps that is not justified.

sgdecker commented 2 years ago

@akrherz For the record, I dumped the Gemenviron.profile file from this branch into ShellCheck, and it found plenty to complain about it, but the specific line in question here was fine. It's probably OK either way.

akrherz commented 2 years ago

@sgdecker Thanks, I did not know about shellcheck! I'll take this PR in a few days unless anybody objects!