search

Unidata / ncWMS

Snapshots of ncWMS used by TDS
8 stars 7 forks source link

Allow reading a timeseries from an existing GridDatatype #18

Closed joanpau closed 8 years ago

joanpau commented 8 years ago

Move the heavy part of reading a timeseries from a dataset to a more specific function receiving an existing GridDatatype, and implement the reading from a dataset using that delegated function. This is the same approach already used for readHorizontalPoints, and allows to reuse the code for the layer implementation in Thredds (socib/thredds@timeseries_fast_read).

See Unidata/thredds#439.

lesserwhirls commented 8 years ago

@guygriffiths - this seems like it's a pretty good boost in performance. Do you see any issues with the small snippet added to CdmUtils (note this is the old ncwms, not the new edal stuff). Thanks!

guygriffiths commented 8 years ago

No, looks like a fairly simple change, I can't see any issues with it.

lesserwhirls commented 8 years ago

Awesome, thanks @guygriffiths!