search

Unidata / netcdf-c

Official GitHub repository for netCDF-C libraries and utilities.
BSD 3-Clause "New" or "Revised" License
508 stars 262 forks source link

_MSC_VER -> _WIN32 #1108

Open DennisHeimbigner opened 6 years ago

DennisHeimbigner commented 6 years ago

It appears that at some point, cygwin's gcc changed to no longer define _WIN32. So we should begin experimenting with converting all references to _MSC_VER with _WIN32 (or in some cases _WIN64). It would be nice to know what changed and when so that we can do some ./configure tests for it. Also need to see if this works under cmake using gcc.

re: https://github.com/Unidata/netcdf-c/issues/1105

WardF commented 5 years ago

@DennisHeimbigner , I'm going through and cleaning up issues that were associated with 4.6.2. Is this still an issue?

DennisHeimbigner commented 5 years ago

I think so. I have been occasionally converting _MSC_VER to _WIN32 as part of various pull requests. But there are still a significant number of occurrences.