Unidata / netcdf-c

Official GitHub repository for netCDF-C libraries and utilities.
BSD 3-Clause "New" or "Revised" License
511 stars 263 forks source link

test_byterange.sh failure with URL3 thredds link #2500

Open abhibaruah opened 2 years ago

abhibaruah commented 2 years ago

NetCDF version: v4.8.1 OS: Linux Debian 11

While trying to build netcdf v4.8.1, we see failures in the test test_byterange.sh. The log file netcdf/Testing/Temporary/LastTest.log has the following log:

73/197 Testing: nc_test_test_byterange
73/197 Test: nc_test_test_byterange
Command: "/usr/local/bin/bash" "-c" "export srcdir=/mathworks/devel/sandbox/abaruah/3p-tmw/3p/derived/glnxa64/netcdf/nc_test;export TOPSRCDIR=/mathworks/devel/sandbox/abaruah/3p-tmw/3p/derived/glnxa64/netcdf;/mathworks/devel/sandbox/abaruah/3p-tmw/3p/derived/glnxa64/netcdf/nc_test/test_byterange.sh "
Directory: /mathworks/devel/sandbox/abaruah/3p-tmw/3p/derived/glnxa64/netcdf/nc_test
"nc_test_test_byterange" start time: Sep 07 12:49 EDT
Output:
----------------------------------------------------------

*** Testing reading NetCDF-3 file with http
***Test remote classic file
/mathworks/devel/sandbox/abaruah/3p-tmw/3p/derived/glnxa64/netcdf/ncdump/ncdump: https://thredds-test.unidata.ucar.edu/thredds/fileServer/pointData/cf_dsg/example/point.nc#mode=bytes: NetCDF: Unknown file format
test_http: -k flag mismatch: expected=classic have=
<end of output>
Test time =   0.35 sec
----------------------------------------------------------
Test Failed.
"nc_test_test_byterange" end time: Sep 07 12:49 EDT
"nc_test_test_byterange" time elapsed: 00:00:00
----------------------------------------------------------

Looks like the failure is only with URL3="https://thredds-test.unidata.ucar.edu/thredds/fileServer/pointData/cf_dsg/example/point.nc#mode=bytes"

When I comment out this URL, the test passes. Also, pasting this link in the browser returns an HTTP Status 404-Not Found. Can someone confirm if this failure is related to https://github.com/Unidata/netcdf-c/issues/2407 ? Or if it is an issue with the thredds server where the file is hosted?

DennisHeimbigner commented 2 years ago

Sorry about that. Recently, thredds-test was de-commissioned so those URLS are no longer supported. I put up a PR to fix this. If you need byterange, then you will need to kill those URLS. Otherwise use option --disable-byterange

abhibaruah commented 2 years ago

Thanks for the update. For now, we can remove those URLs. Will the test dap4_test/test_thredds.sh be removed/updated as well?

DennisHeimbigner commented 2 years ago

Yes, I am eliding all thredds-test URLs. I will probably re-introduce the equivalents when I can find an alternate server.