auto data/define swith; no except. in dtor; addVar for scalars; open+format in ncFile ctor

Unidata / netcdf-cxx4

Official GitHub repository for netCDF-C++ libraries and utilities.

Other

124 stars 49 forks source link

auto data/define swith; no except. in dtor; addVar for scalars; open+format in ncFile ctor #10

Closed slayoo closed 10 years ago

slayoo commented 10 years ago

Hi,

76a61b9: With this patch, when working on classic files, the data/define mode swithing is done automatically by the library (see example in cxx4/test_classic.cpp).

0d1698d: Avoiding undefined behaviour when an exception is being thrown while handling an exception

fb1f81a: addVar() version for scalar variables

920860a: opening files with non-default format in NcFile ctor

HTH, Sylwester

russrew commented 10 years ago

I'm going to accept this backward-compatible pull request before the previous "Exception hierarchy" pull request, which I think requires a bit more discussion, because it is not backward compatible. The same minor merge conflict occurs in cxx4/ncGroup.cpp, requiring replacement of "throw NcNullGroup" with "throw NcException" in 2 places, regardless of the order in which these two pull requests are merged.