Unidata / netcdf-cxx4

Official GitHub repository for netCDF-C++ libraries and utilities.
Other
124 stars 49 forks source link

Implement move semantics for NcFile/NcGroup (fixes #60) #68

Closed ZedThree closed 5 years ago

ZedThree commented 5 years ago

This is just #60 + fix and (very basic) test.

Fix was just to move the NcGroup(NcGroup&&) and NcGroup& operator=(NcGroup&&) move constructor and move-assignment operator from ncFile.h into ncGroup.h. I've also added a very simple test to demonstrate it works. Without the move constructors, this test will not compile.

WardF commented 5 years ago

Thanks!

WardF commented 5 years ago

Having an error on OSX, reverting while I sort it out.