Closed tdrwenski closed 1 year ago
Two grib coverage tests failing on Jenkins: https://jenkins-aws.unidata.ucar.edu/view/Users/job/tara-netcdf-java/22/testReport/junit/
Jenkins tests passing: https://jenkins-aws.unidata.ucar.edu/view/Users/job/tara-netcdf-java/23/ after fix for coverage axes sort order when the coverage is grib 2b67152
Description of Changes
This resolves https://github.com/Unidata/netcdf-java/issues/1220
Coverages with both a time and an ensemble axis do not work due to a mismatch in the canonical order
canonical order: (rt, e, t, z, y, x)
used inDTCoverage::calcPermuteIndex()
and the sort order for theAxisType
enums used for ordering the CoordinateAxes in the coverage coordinate system. This would cause errors upon reading/writing due to index out of bounds.This PR would use the
canonical order: (rt, e, t, z, y, x)
for theAxisType
enum as well. There is a comment saying not to change the enum order due to its use in protobuf messages. The only proto that I see this used in is thecdmrFeature.proto
which actually has the order I just updatedAxisType
to have. It seems that cmdrFeature is removed in TDS and so I am not sure how important it is to test that.Additional TDS tests added in https://github.com/Unidata/tds/pull/411.
PR Checklist