Closed allanfrankwork closed 5 months ago
I have found some files that this still does not work on, setting PR to draft.
I'll update here when I know more.
Hi @allanfrankwork, are you still working on this PR?
I am not.
IIRC, while trying to parse BUFR files from WIS2 I found a couple of different templates that were in slightly different format and the parsing function did not handle those variations.
I will close this PR.
Thanks.
Description of Changes
Fixes line parsing for ECMWF BUFR templates.
I was parsing BUFR files and noticed that even the included ecmwf.D0000000000098013001.TXT file failed to be parsed due to comments after the three sections of numbers in some lines.
For the BUFR files I am parsing I'm using other templates which have the same problem - so I worked around that by cutting off the lines before handing them to tablelookup.csv and calling NetcdfFiles.openInMemory(filename)
However with this fix no such workaround is needed and since its also a problem for the file already in netcdf-java/bufr/src/main/resources/resources/bufrTables/local/ecmwf.D0000000000098013001.TXT I thought it would be good to include for all.
For unittest I tried including the file in netcdf-java/bufr/src/test/data but that makes the unittest fail - I suspect due missing bufr templates. If you have other ideas to try please let me know.
PR Checklist