Added support to parse variable length char element from ncml

Unidata / netcdf-java

The Unidata netcdf-java library

https://docs.unidata.ucar.edu/netcdf-java/current/userguide/index.html

BSD 3-Clause "New" or "Revised" License

142 stars 69 forks source link

Added support to parse variable length char element from ncml #1236

Closed jmasson-l3h closed 12 months ago

jmasson-l3h commented 12 months ago

Description of Changes

Added support to parse variable length tokens for char arrays in the ncml reader. This is to help resolve issue #1235

PR Checklist

[ ] Link to any issues that the PR addresses
[ ] Add labels
[ ] Open as a draft PR until ready for review
[ ] Make sure GitHub tests pass
[ ] Mark PR as "Ready for Review"

CLAassistant commented 12 months ago

All committers have signed the CLA.

mnlerman commented 12 months ago

@jmasson-l3h thank you for your contribution! The code looks good but please sign the CLA so that we can review and merge it.

jmasson-l3h commented 12 months ago

@jmasson-l3h thank you for your contribution! The code looks good but please sign the CLA so that we can review and merge it.

Hello , when attempting to sign that I get "Internal Server Error" on url "https://cla-assistant.io/auth/github/callback?code=9d9c182fce4a29a1e7a6" .

Is there another mechanism to sign ?

mnlerman commented 12 months ago

https://cla-assistant.io/Unidata/netcdf-java?pullRequest=1236 Try this link

jmasson-l3h commented 12 months ago

https://cla-assistant.io/Unidata/netcdf-java?pullRequest=1236 Try this link

Same issue with the internal server error. I will try on my personal computer later tonight.

mnlerman commented 12 months ago

Ahh hmm, I got the internal server error when I opened the link you provided but I was able to open the one that I sent. I wonder if the problem is associated with this message from above:

Jeffrey Masson seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it.

jmasson-l3h commented 12 months ago

Ahh hmm, I got the internal server error when I opened the link you provided but I was able to open the one that I sent. I wonder if the problem is associated with this message from above:

Jeffrey Masson seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it.

I was able to do it from home, was probably a network/security issue on my side.