Unidata / netcdf-java

The Unidata netcdf-java library
https://docs.unidata.ucar.edu/netcdf-java/current/userguide/index.html
BSD 3-Clause "New" or "Revised" License
142 stars 69 forks source link

fix scale offset applied twice #1247

Closed haileyajohnson closed 9 months ago

haileyajohnson commented 11 months ago

fix scale offset applied twice

remove extra calls to convert for performance

haileyajohnson commented 9 months ago

The scale/offset applied twice by nccs and the TDS bug is being tested already by all the tests that check that the scale and offset properties are removed, but I was also planning on putting a test in the TDS. The thing with the time axes calling read and convert over and over is kinda hard to test because it doesn't actually change any results, so for me to test it I had to manually count how many times that code was hit...